Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reporter action doesn't fail on PRs from forked repositories #29

Open
andrewiggins opened this issue Oct 4, 2020 · 2 comments
Open

Comments

@andrewiggins
Copy link
Owner

See benchmark run here for an example: https://github.com/Polymer/lit-html/pull/1322/checks

@andrewiggins
Copy link
Owner Author

Snapshot of sample failing logs (in case github cleans them up):
image

@andrewiggins
Copy link
Owner Author

andrewiggins commented Jan 22, 2021

To fix this, let's add support for the workflow_run event trigger. Benchmarks should be run in the pull_request event and the result json files uploaded as artifacts. When it finishes, it should trigger another workflow that consumes the JSON files as an artifact and runs this action to create/update the comment.

Note, the workflow_run should run for the requested and completed events so it can report running status on comments when the benchmark run starts.

Blog posts to reference:

Other things to consider:

  • Perhaps add a pr_number input to allow people to manually specify the pr that workflow_run should update.
  • If no pr_number is available, then we could try to guess which pr from one of the properties of context should be used. Perhaps pick the most recently updated open PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant