Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User callback for argument completion #201

Open
ALSchwalm opened this issue Jun 6, 2019 · 2 comments
Open

User callback for argument completion #201

ALSchwalm opened this issue Jun 6, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ALSchwalm
Copy link
Contributor

It would be nice to allow users to register callbacks for completing a command. This would allow them to keep the normal completion logic we have while getting custom stuff for completing e.g. git. It would also save people from needing to redundantly implement parsing logic, etc. I'm thinking something like: https://elv.sh/ref/edit.html#argument-completer

It would probably be best to wait to do this until after janet-lang/janet#121 is implemented, but I thought I'd go ahead and open an issue.

@andrewchambers andrewchambers added the enhancement New feature or request label Jun 6, 2019
@andrewchambers
Copy link
Owner

andrewchambers commented Jun 6, 2019

I think it is reasonable to guide people in the right direction on this without necessarily implementing everything ourselves, so I agree a common extension point is reasonable.

@andrewchambers
Copy link
Owner

Another thought, once the coprocess function is added, people can spawn completion servers implemented in other shells which will be cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants