Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawnLimit in ore gens isnt used right when stacking items #858

Open
IIHERO4 opened this issue Aug 11, 2023 · 4 comments · May be fixed by #859
Open

spawnLimit in ore gens isnt used right when stacking items #858

IIHERO4 opened this issue Aug 11, 2023 · 4 comments · May be fixed by #859

Comments

@IIHERO4
Copy link
Contributor

IIHERO4 commented Aug 11, 2023

I believe this should be += i.getItemStack().getAmount() instead of ++

BedWars1058/bedwars-plugin/src/main/java/com/andrei1058/bedwars/arena/OreGenerator.java

Line 160 in 9a0c438

oreCount++;

IIHERO4 added a commit to IIHERO4/BedWars1058 that referenced this issue Aug 11, 2023
@IIHERO4
Fix gen spawn limit
d7ff13c 
Fixes andrei1058#858
@IIHERO4 IIHERO4 linked a pull request Aug 11, 2023 that will close this issue
Open
@andrei1058
Copy link
Owner

Why?

@andrei1058
Copy link
Owner

oh wait, is this related to the stack items option?

@andrei1058
Copy link
Owner

but it only counts drops. I don't get it

@IIHERO4
Copy link
Contributor Author

IIHERO4 commented Aug 24, 2023

but it only counts drops. I don't get it

Vanilla Minecraft I believe group some items to one item stack, so instead of two entities with amount of 1, it will make 1 entity with amount of 2

To be fair i dont remember if i used a spigot fork or not but when i printed the itemStack.getAmount it wasnt always 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gen spawn limit IIHERO4/BedWars1058
2 participants
@andrei1058 @IIHERO4