Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not work in Windows #4

Open
Human-Investment opened this issue Apr 9, 2020 · 4 comments
Open

Not work in Windows #4

Human-Investment opened this issue Apr 9, 2020 · 4 comments

Comments

@Human-Investment
Copy link

It works fine on Mac.

MojiConverter converter = new MojiConverter();
String name = converter.convertKanaToRomaji("アキラ");

It returns アキラ but not akira in romaji

@ssttkkl
Copy link

ssttkkl commented Jul 5, 2020

Maybe I am meeting the same issue. It works perfectly in IDEA, but fails to work once I pack my application as a jar.

@barry-evans-paidy
Copy link

barry-evans-paidy commented Jun 23, 2022

May i ask if this issue is going to be fixed? @andree-surya
I am developing on a Windows machine and need to use this library in my project.

I would be happy to work on a fix and open a PR if the fix is relatively simple to fix.

@andree-surya
Copy link
Owner

Hello @barry-evans-paidy , thank for bumping-up this issue. Unfortunately, I don't have direct access to Windows machine where I can reproduce the issue, but I would be happy to receive a PR from you. Please do let me know should you need help.

@barry-evans-paidy
Copy link

Thanks @andree-surya, I will fork your repo and open a PR. I should be able to reproduce the problem on my local Windows machine.

It is a simple enough fix, which others seem to have implemented in a branch in their own forks of this repo:

  • BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, StandardCharsets.UTF_8));

I will be in touch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants