Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP listener should use select() for waiting for a new client #37

Open
loganek opened this issue Aug 26, 2018 · 0 comments
Open

TCP listener should use select() for waiting for a new client #37

loganek opened this issue Aug 26, 2018 · 0 comments

Comments

@loganek
Copy link
Member

loganek commented Aug 26, 2018

Currently in TCPListener we use accept() function to accept new connections. However, this function is blocking, and can't be interrupted, therefore test ApplicationShouldNotCrashWhenCreatingListenerFails hangs on mac os. If we rewrite tcp listener so it uses multiplexers (select()) we can use pipes to unblock the thread.
loganek added a commit that referenced this issue Aug 26, 2018
@loganek
[tests] temporarily disable tcp listener tests
8097bd5 
This test shoudl be enabled when we fix following issue:
#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loganek