Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force to use amp-img option attribute in amp-carousel #22378

Closed
imansa opened this issue May 19, 2019 · 3 comments
Closed

force to use amp-img option attribute in amp-carousel #22378

imansa opened this issue May 19, 2019 · 3 comments
Assignees

Comments

@imansa
Copy link

imansa commented May 19, 2019

according to following documents, on Image gallery with preview part we must use option attribute on amp-img tags to make a slider with preview

amp-carousel sample document

What's the issue?

according to amp-carousel documents on Image gallery with preview part, we must use option attribute on amp-img tags to make a slider with preview. but option attribute is not in amp-img allowed attributes in standard and will be removed by amp validators like this one

How do we reproduce the issue?

it is about amp-carousel standard an is visible in it's sample page and do not need any test case

What browsers are affected?

All browsers

Which AMP version is affected?

1905091827220

@aghassemi
Copy link
Contributor

Hi @imansa option attribute becomes valid when inside amp-selector, which is needed to make that example work. You can also use amp-bind to make a a photo gallery. One of the codelabs we have (Building Beautiful, interactive, canonical AMP pages) takes you through both approaches.

Hope this helps

-Ali

@aghassemi aghassemi self-assigned this May 20, 2019
@imansa
Copy link
Author

imansa commented May 21, 2019

Hi Ali

you said "option attribute becomes valid when inside amp-selector". where is it's document ? i am try to create an issue like this one on validator to fix it's problems. but i need some document to show my issue is valid according to amp standards. being a attribute valid when tag is child of other tag is some complex and i do not know how to find it's document for it and same problems in future.

thanks a lot

@aghassemi
Copy link
Contributor

@imansa option is an attribute that is meant for children of amp-selector per https://amp.dev/documentation/components/amp-selector but those children can by anything themselves (e.g. div, amp-img, etc..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants