Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amp-options an autoloaded option #3287

Open
westonruter opened this issue Sep 18, 2019 · 2 comments
Open

Make amp-options an autoloaded option #3287

westonruter opened this issue Sep 18, 2019 · 2 comments
Labels
Enhancement New feature or improvement of an existing one Groomed P2 Low priority Performance Punted WS:Perf Work stream for Metrics, Performance and Optimizer

Comments

@westonruter
Copy link
Member

On accessing the frontend, there is a persistent query for the amp-options option:

Screen Shot 2019-09-17 at 22 25 04

Given that this option is always queried with each request, the option should be made autoloaded (part of alloptions).

@westonruter westonruter added Enhancement New feature or improvement of an existing one Performance labels Sep 18, 2019
@westonruter westonruter added this to the v1.3.1 milestone Sep 18, 2019
@MackenzieHartung
Copy link

Note: For now, Analytics will be decoupled from the other AMP options stored, and remain not autoloaded.

@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
@westonruter westonruter removed this from the v1.4 milestone Oct 17, 2019
@kmyram kmyram added the P2 Low priority label Feb 18, 2020
@amedina amedina removed the Size: S label Mar 31, 2020
@kmyram kmyram added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 5, 2020
@kmyram kmyram added the Groomed label Nov 24, 2020
@kmyram kmyram added this to the v2.1 milestone Nov 24, 2020
@westonruter
Copy link
Member Author

We should make sure that any related WordPress core issues related to autoloaded options don't cause headaches here. I recall at a time that there was a bug in core where multiple updates to an autoloaded option could cause some updates to be lost. If this issue is still current, then it will be a problem for the AMP plugin since amp-options stores multiple settings that could receive more than one update in a request.

@westonruter westonruter modified the milestones: v2.1, v2.2 Feb 11, 2021
@westonruter westonruter modified the milestones: v2.2, v2.3 Nov 30, 2021
@westonruter westonruter modified the milestones: v2.3, v2.4 Dec 23, 2021
@westonruter westonruter removed this from the v2.4 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one Groomed P2 Low priority Performance Punted WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
Archived in project
Development

No branches or pull requests

5 participants