From 88336ebe1f61822c1569544ab4822938106bb069 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Wed, 16 Oct 2024 09:40:02 -0400 Subject: [PATCH] Clean up unnecessary logs (#21333) --- app/controllers/articles_controller.rb | 3 --- app/controllers/stories_controller.rb | 4 ---- app/controllers/users_controller.rb | 3 --- 3 files changed, 10 deletions(-) diff --git a/app/controllers/articles_controller.rb b/app/controllers/articles_controller.rb index 28d04d100d1f2..757233a161f43 100644 --- a/app/controllers/articles_controller.rb +++ b/app/controllers/articles_controller.rb @@ -273,10 +273,8 @@ def base_editor_assignments def handle_user_or_organization_feed if (@user = User.find_by(username: params[:username])) - Honeycomb.add_field("articles_route", "user") @articles = @articles.where(user_id: @user.id) elsif (@user = Organization.find_by(slug: params[:username])) - Honeycomb.add_field("articles_route", "org") @articles = @articles.where(organization_id: @user.id).includes(:user) end end @@ -297,7 +295,6 @@ def set_article Article.includes(:user).find(params[:id]) end @article = found_article || not_found - Honeycomb.add_field("article_id", @article.id) end # TODO: refactor all of this update logic into the Articles::Updater possibly, diff --git a/app/controllers/stories_controller.rb b/app/controllers/stories_controller.rb index 1d1a045c8e322..68454d0bd877f 100644 --- a/app/controllers/stories_controller.rb +++ b/app/controllers/stories_controller.rb @@ -111,20 +111,16 @@ def handle_user_or_organization_or_podcast_or_page_index @organization = Organization.find_by(slug: params[:username]) @page = Page.find_by(slug: params[:username], is_top_level_path: true) if @podcast - Honeycomb.add_field("stories_route", "podcast") handle_podcast_index elsif @organization - Honeycomb.add_field("stories_route", "org") handle_organization_index elsif @page if FeatureFlag.accessible?(@page.feature_flag_name, current_user) - Honeycomb.add_field("stories_route", "page") handle_page_display else not_found end else - Honeycomb.add_field("stories_route", "user") handle_user_index end end diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 22b5ad19ba372..6c0784f06f349 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -63,9 +63,6 @@ def update format.html { redirect_to "/settings/#{@tab}" } end else - Honeycomb.add_field("error", @user.errors.messages.compact_blank) - Honeycomb.add_field("errored", true) - error_message = @user.errors.full_messages.join(", ") respond_to do |format|