You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when we compare two ISL models it accounts for the order of types, imports or constraints. It uses Vec to store all the types, imports and constraints information. This should be changed to use HashSet instead which can help with the equivalence of two schema models.
Also, ion-rust has IonData which stores a reference to the Element this can be used for the Ion elements related constraints like valid_values, contains.
The text was updated successfully, but these errors were encountered:
desaikd
changed the title
Change ISL model to preserve order of types, imports and constraints
Equivalence for two ISL models shoudn't consider order of types, imports and constraints
Jun 12, 2023
Currently when we compare two ISL models it accounts for the order of types, imports or constraints. It uses
Vec
to store all the types, imports and constraints information. This should be changed to useHashSet
instead which can help with the equivalence of two schema models.Also,
ion-rust
hasIonData
which stores a reference to theElement
this can be used for the Ion elements related constraints likevalid_values
,contains
.The text was updated successfully, but these errors were encountered: