Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equivalence for two ISL models shoudn't consider order of types, imports and constraints #184

Open
desaikd opened this issue Jun 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@desaikd
Copy link
Contributor

desaikd commented Jun 12, 2023

Currently when we compare two ISL models it accounts for the order of types, imports or constraints. It uses Vec to store all the types, imports and constraints information. This should be changed to use HashSet instead which can help with the equivalence of two schema models.
Also, ion-rust has IonData which stores a reference to the Element this can be used for the Ion elements related constraints like valid_values, contains.

@desaikd desaikd added the enhancement New feature or request label Jun 12, 2023
@desaikd desaikd changed the title Change ISL model to preserve order of types, imports and constraints Equivalence for two ISL models shoudn't consider order of types, imports and constraints Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant