Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ISL constraints in a type definition for generating code #108

Open
desaikd opened this issue May 8, 2024 · 0 comments
Open

Sort ISL constraints in a type definition for generating code #108

desaikd opened this issue May 8, 2024 · 0 comments
Labels
code generation Improvements for code generation subcommand `generate`

Comments

@desaikd
Copy link
Contributor

desaikd commented May 8, 2024

Code generation uses logic to find some of the constraints like type, element in order to determine the final abstract data type. This would be simplified with some sorting of ISL constraints to get name, type(base type) etc.

It seems like there's a fair amount of complexity here that's dedicated to accommodating the ISL fields appearing in unpredictable orders. I think we could easily sort the fields beforehand so we could process them more easily, guaranteeing that we see name before type before element, etc.

@desaikd desaikd added the code generation Improvements for code generation subcommand `generate` label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code generation Improvements for code generation subcommand `generate`
Projects
Status: No status
Development

No branches or pull requests

1 participant