Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Move Braket-specific pragma, instruction, and result logic out of parser #53

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Represent instructions and result types using named tuples to avoid forcing everyone into Braket's representation. Instead, let packages define for themselves how to parse and visit pragmas and how to turn these named tuples into their own types.

Testing done: Tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner September 25, 2024 00:49
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (4780fdf) to head (9e8aac0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   99.18%   98.89%   -0.29%     
==========================================
  Files          22       23       +1     
  Lines        3423     3453      +30     
==========================================
+ Hits         3395     3415      +20     
- Misses         28       38      +10     
Flag Coverage Δ
98.89% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws
Copy link
Member Author

Checked that this works with the Python wrapper as well

@kshyatt-aws
Copy link
Member Author

OK I think this failing codecov check is spurious. @rmshaffer does this look ok to you?

@kshyatt-aws kshyatt-aws merged commit 98ee205 into main Sep 27, 2024
13 of 14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/no_ixs branch September 27, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants