-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Move Braket-specific pragma, instruction, and result logic out of parser #53
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 99.18% 98.89% -0.29%
==========================================
Files 22 23 +1
Lines 3423 3453 +30
==========================================
+ Hits 3395 3415 +20
- Misses 28 38 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Checked that this works with the Python wrapper as well |
OK I think this failing codecov check is spurious. @rmshaffer does this look ok to you? |
Issue #, if available: N/A
Description of changes: Represent instructions and result types using named tuples to avoid forcing everyone into Braket's representation. Instead, let packages define for themselves how to parse and visit pragmas and how to turn these named tuples into their own types.
Testing done: Tests passed locally.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.