change: Remove PythonCall dep and extension #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 23 22 -1
Lines 3339 3367 +28
=======================================
+ Hits 3307 3335 +28
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rmshaffer
reviewed
Sep 18, 2024
Comment on lines
+399
to
+408
| mmap_files = String[] | ||
| obj_lengths = Int[] | ||
| for r_ix in to_mmap | ||
| push!(obj_lengths, length(results.resultTypes[r_ix].value)) | ||
| tmp_path, io = mktemp() | ||
| write(io, results.resultTypes[r_ix].value) | ||
| empty!(results.resultTypes[r_ix].value) | ||
| close(io) | ||
| push!(mmap_files, tmp_path) | ||
| end |
There was a problem hiding this comment.
For my own understanding: you're using the variable name mmap_files, but actually these are just temp files on disk, is that correct? Or is there something else happening here?
There was a problem hiding this comment.
mmap_files is the path to each file where the big array is mmap-ed. These files are in /tmp and are deleted when the Julia process exits.
rmshaffer
previously approved these changes
Sep 24, 2024
rmshaffer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Use JSON strings to pass inputs and results back and forth to external callers (inc. Python). Means we no longer need a PythonCall extension. Use
mmaped files for large datasets (e.g. state vectors or density matrices) to avoid very expensive inter-process communication.Testing done: Unit tests passed locally and works with coming branch for Python wrapper.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.