Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Configurable color space #2426

Open
nowak-pl opened this issue Sep 25, 2024 · 3 comments
Open

feature request: Configurable color space #2426

nowak-pl opened this issue Sep 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@nowak-pl
Copy link

Currently ALVR sets color space to DCI-P3 in client.

xr_session.set_color_space(xr::ColorSpaceFB::P3).unwrap();

It would be nice to have selectable color space in streamer because content authored in Rec. 709 or sRGB doesn't look the best when expanded to P3 without proper conversion and then clipped to HMD LCD panel native color space.

@zmerp
Copy link
Member

zmerp commented Sep 25, 2024

We are limited by the codec standards. It is best not to needlessly change the color space before encoding because that will exacerbate color aliasing (banding).

Or I may be misinterpreting your question. We could add an option on the streamer to instruct the client to use a specific color space.

@nowak-pl
Copy link
Author

I'm only talking about sending to client which color space should it use in set_color_space call, no conversions on either end.

@zmerp
Copy link
Member

zmerp commented Sep 26, 2024

Yeah it can be done. There is a openxr extension to do that. I'll accept PR to implement it.

@The-personified-devil The-personified-devil added the enhancement New feature or request label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants