Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build script assumes that rustup is always in ~/.cargo/bin/ #14

Open
drozdziak1 opened this issue Feb 1, 2018 · 1 comment
Open

Comments

@drozdziak1
Copy link
Contributor

What's happening?

Our build script installs the toolchains necessary for each supported platform. It seems to call rustup directly via $HOME/.cargo/bin/rustup which isn't always its correct location.

Why's that a problem?

Someone might have rustup already installed in a non-standard setup of their choosing (Rustup's install script lets you customize the install so that's entirely possible). This causes the build to fail because of No such file or directory being returned when the build tries to run Rustup that way.

Solutions

The easiest solution would most likely be refering to just rustup instead of the full path within the build scripts

@jkilpatr
Copy link
Member

jkilpatr commented Jun 8, 2018

the alternative is modifying someone's path for them. I guess the easy installer should do that as a matter of course though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants