Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-GRPC querier #328

Open
4 tasks
jkilpatr opened this issue Sep 6, 2021 · 0 comments
Open
4 tasks

Remove pre-GRPC querier #328

jkilpatr opened this issue Sep 6, 2021 · 0 comments
Labels
bug Something isn't working First Issue This is a good first issue Gravity Module cosmos sdk module

Comments

@jkilpatr
Copy link
Member

jkilpatr commented Sep 6, 2021

https://github.com/althea-net/cosmos-gravity-bridge/blob/main/module/x/gravity/keeper/querier.go

Is an unused file, this file used to back ABCI requests (the old query method for cosmos)

Now days it's mostly unused, except for one small but essential piece of code the contract deployer uses the 'QueryCurrentValset' endpoint. All of the others are totally unused.

PeggyJV has invested a non-trivial amount of time into adding GRPC support to the contract deployer and get around this issue.

As part of this issue

  • evaluate if it's worth importing grpc support for contract deployer
  • Use Github authoring features to ensure the original authors are credited if anything is imported.
  • Delete all methods except QueryCurrentValset, or the entire querier.go file
  • Transition all unit tests in queryier_test.go to test the grpc implementations.
@jkilpatr jkilpatr added bug Something isn't working Gravity Module cosmos sdk module First Issue This is a good first issue labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working First Issue This is a good first issue Gravity Module cosmos sdk module
Projects
None yet
Development

No branches or pull requests

1 participant