Skip to content

Latest commit

 

History

History
74 lines (53 loc) · 2.34 KB

CONTRIBUTING.md

File metadata and controls

74 lines (53 loc) · 2.34 KB

Contributing

This repository is NOT open for pull requests outside of the limited set of people due to missing CLA. Please file issues instead for proposals and issues reporting. We are working on removing this limitation and allowing contributions.

Style

We follow the Google Java Style Guide. Our build automatically will provide warnings for simple style issues.

Run the following command to format all files. This formatter uses google-java-format:

OS X or Linux

./gradlew goJF

Windows

gradlew.bat goJF

We also follow these project-specific guidelines:

Javadoc

  • All public classes and their public and protected methods MUST have javadoc. It MUST be complete (all params documented etc.) Everything else (package-protected classes, private) MAY have javadoc, at the code writer's whim. It does not have to be complete, and reviewers are not allowed to require or disallow it.
  • Each API element should have a @since tag specifying the minor version when it was released (or the next minor version).
  • There MUST be NO javadoc errors.
  • See section 7.3.1 in the guide for exceptions to the Javadoc requirement.
  • Reviewers may request documentation for any element that doesn't require Javadoc, though the style of documentation is up to the author.
  • Try to do the least amount of change when modifying existing documentation. Don't change the style unless you have a good reason.
$ git checkout -b docs
$ ./gradlew javadoc
$ cp -R api/build/docs/javadoc/* docs
$ git add -A .
$ git commit -m "Update javadoc for API."

AutoValue

  • Use AutoValue, when possible, for any new value classes. Remember to add package-private constructors to all AutoValue classes to prevent classes in other packages from extending them.

Building openconsensus-java

Continuous integration builds the project, runs the tests, and runs multiple types of static analysis.

Run the following commands to build, run tests and most static analysis, and check formatting:

OS X or Linux

./gradlew clean assemble check verGJF

Windows

gradlew.bat clean assemble check verGJF