Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development is not possible using govuk-docker #267

Closed
KludgeKML opened this issue Apr 20, 2022 · 3 comments
Closed

Development is not possible using govuk-docker #267

KludgeKML opened this issue Apr 20, 2022 · 3 comments
Assignees

Comments

@KludgeKML
Copy link
Contributor

KludgeKML commented Apr 20, 2022

The main branch of govuk-docker is now M1-compatible, and part of that is removing the mongo-2.6 container and pointing router to mongo-3.6. This will work for general use, but the router-3.6 container in govuk-docker is not set up to use a replica set, which docker relies on to detect updates to the data. This will causes failures in the following situations:

  • developers actively working on router will not be able to run the test suite
  • developers using the stack in govuk-docker who publish new content and expect it to appear in their local dev environment through router (rather than directly accessed) will not see that new content.

This issue is related in part to this one: #210

Developers needing a workaround should try this govuk-docker branch which sets mongo-3.6 to use the replica set:
https://github.com/alphagov/govuk-docker/tree/m1-compatibility-keith

Alternatively, work in this router branch will render this replica-set requirement moot when complete:
https://github.com/alphagov/router/tree/change-stream

(This issue repeated in govuk-docker since it's not 100% clear where it should be, since the fix is in both places: alphagov/govuk-docker#591)

@chao-xian
Copy link
Contributor

@KludgeKML should your m1-compatibility-keith branch changes be a PR now?

@KludgeKML
Copy link
Contributor Author

It shouldn't - I think there are better ways to progress on this. I'll DM you (and we can update / close this when decisions are made).

@sengi
Copy link
Contributor

sengi commented Feb 12, 2024

It doesn't look like anyone's actually needed to run Router in govuk-docker in the past 3 years or so. We hope to start replacing govuk-docker use cases with Kubernetes soon, so it'll become possible to run end-to-end tests locally.

@sengi sengi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants