Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Case insensitive input #98

Open
OllieJC opened this issue Aug 10, 2020 · 2 comments
Open

[Feature Request] Case insensitive input #98

OllieJC opened this issue Aug 10, 2020 · 2 comments

Comments

@OllieJC
Copy link
Member

OllieJC commented Aug 10, 2020

Currently, [email protected] will result in an error.
Allow different case and then change to lower - for former, I think adding A-Z to the regular expressions will work:

/\A([a-z.\-\']+@digital\.cabinet-office\.gov\.uk,?\s*)+\z/,

Like: /\A([A-Za-z.\-\']+@digital\.cabinet-office\.gov\.uk,?\s*)+\z/,

@philandstuff
Copy link
Contributor

Allow different case and then change to lower

Is this the right behaviour? It seems like it makes assumptions about how our email is managed... (I think with G Suite it's fine, I don't know about cabinetoffice.gov.uk though)

@OllieJC
Copy link
Member Author

OllieJC commented Aug 10, 2020

@philandstuff technically the local part is case sensitive and the domain is insensitive. We don't have to convert to lower case, but we should allow any case or at the very least tell users to use lower case (if that's what we're suggesting?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants