Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all timestamp fields to Time vs DateTime #1126

Open
floehopper opened this issue May 22, 2017 · 0 comments
Open

Convert all timestamp fields to Time vs DateTime #1126

floehopper opened this issue May 22, 2017 · 0 comments
Milestone

Comments

@floehopper
Copy link
Contributor

Some timestamp fields (ManualRecord::Edition#originally_published_at & SectionEdition#exported_at) are of type DateTime; whereas timestamp fields defined via Mongoid::Timestamps are of type Time. In my experience, it's better to use Time in Ruby unless you are dealing with different types of calendar, e.g. Gregorian, Julian, etc. If nothing else we should make all timestamp fields have the same type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant