Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should AssetPresenter#as_json be using Plek#public_asset_host vs Plek#asset_root #443

Open
floehopper opened this issue Jan 29, 2018 · 0 comments
Labels

Comments

@floehopper
Copy link
Contributor

floehopper commented Jan 29, 2018

See this line of code:

file_url: URI.join(Plek.new.asset_root, Addressable::URI.encode(@asset.public_url_path)).to_s,

I think Plek#public_asset_host will return assets.publishing.service.gov.uk in production whereas I think Plek#asset_root will return assets-origin.publishing.service.gov.uk. I haven't thought about it very carefully, but I think we want the former rather than the latter.

@floehopper floehopper added the bug label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant