-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty Carrierwave directories when asset file is removed #385
Comments
Note that for completeness, we may want to remove the empty directories from the |
I've opened #390 to address this issue for new assets in order that the disk usage for Asset Manager assets doesn't increase and trigger the asset master/slave disk usage alert once alphagov/govuk-puppet#7016 has been applied and Asset Manager assets are no longer being sync-ed from asset master to asset slaves. We will need to decide what to do about existing empty directories separately. |
I've just merged #390. |
#390 has just been deployed to staging (@ ~10:35). |
#390 has just been deployed to production (@ ~10:45). |
We still need to remove the existing empty directories. I'm going to add a checklist to the description to make that more obvious. |
I'm going to move this back in to the To Do column so we can decide when/if to prioritise the remaining work. |
I'm going to un-assign myself from this issue since I'm no longer actively working on it. |
When we implemented #296, we didn't remove the directories as well as the files. This shouldn't cause any immediate problem, but it might be a bit confusing to people, so it would be good to stop the app leaving these directories lying around and to remove all the existing ones.
The text was updated successfully, but these errors were encountered: