Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing assets are still clean when a new virus definition is released #330

Open
chrislo opened this issue Dec 7, 2017 · 2 comments

Comments

@chrislo
Copy link
Contributor

chrislo commented Dec 7, 2017

The current implementation of virus scanning in Whitehall rescans all existing assets when a new virus definition file for ClamAV is released.

Asset manager currently does not do that so if we are going to unify the functionality of the two applications we should consider what to do about this feature.

It is noted that the full re-scan of assets takes around 2 days and uses a lock to ensure the process only runs once at a time. If we do implement this feature in Asset Manager we may decide to do it in a different way to avoid this problem.

@chrisroos
Copy link
Contributor

I've added this to the "Bring Whitehall & Mainstream asset behaviour into line with each other" milestone as I think we'll need to do it to ensure we retain the existing Whitehall functionality.

@floehopper
Copy link
Contributor

Daniel has said that there's no specific requirement for this, although it would be a nice-to-have. He's added it to the tech debt and risk registers and said that it's fine for us to de-scope this work.

However, I think it's still worth keeping the issue in case we get a chance to work on it and/or as a reminder to whoever we handover the project to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants