Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TimeFrame Units To Class Definition #641

Open
1 task done
fisher60 opened this issue Jul 19, 2022 · 0 comments
Open
1 task done

Move TimeFrame Units To Class Definition #641

fisher60 opened this issue Jul 19, 2022 · 0 comments

Comments

@fisher60
Copy link

fisher60 commented Jul 19, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

The unit attributes for the TimeFrame class are assigned after the TimeFrame class is defined. This results in intellisense being unable to find/recognize these attributes as being a part of the class and makes writing this code more difficult.

Describe the solution you'd like.

The TimeFrame Unit definitions should be added as class attributes or as properties of the TimeFrame class. This would allow intellisense to autocomplete the code and identify the attributes as existing in code. This also helps to make the code a bit easier to read and more self-documenting

Describe an alternate solution.

A python stub file can be used instead of altering the codebase and achieve the same results

Anything else? (Additional Context)

Example of the issue in Pycharm:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant