Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--load_best=true should force checkpoint to be loaded #89

Open
favyen2 opened this issue Jan 15, 2025 · 0 comments
Open

--load_best=true should force checkpoint to be loaded #89

favyen2 opened this issue Jan 15, 2025 · 0 comments

Comments

@favyen2
Copy link
Collaborator

favyen2 commented Jan 15, 2025

Two issues:

  • Currently even if best.ckpt or other checkpoint exists in the project folder, with --load_best=true the checkpoint will only be loaded if last.ckpt also exists since the first check is for last.ckpt. I think it should be updated so with --load_best=true it can load any checkpoint. If this is updated, then we can update the docs/ to avoid needing to rename best.ckpt to last.ckpt when downloading checkpoints.
  • It makes sense for --autoresume=true to continue even if there's no existing checkpoint, but I think --load_best=true should only continue if there's checkpoint instead of continuing with random initialization. Otherwise it is not obvious what the problem is when you are running model test or a prediction pipeline that it is really using random weights.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant