From 115f4154764e7204dc5b9d5c5b6e92d52a5e71c7 Mon Sep 17 00:00:00 2001 From: "nastassia.dailidava" Date: Fri, 18 Oct 2024 22:09:38 +0200 Subject: [PATCH] allegro-internal/flex-roadmap#819 removed snapshot updater timer --- .../servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/envoy-control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt b/envoy-control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt index 2ca421461..2ae488caa 100644 --- a/envoy-control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt +++ b/envoy-control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotUpdater.kt @@ -4,7 +4,6 @@ import io.envoyproxy.controlplane.cache.SnapshotCache import io.envoyproxy.controlplane.cache.v3.Snapshot import io.micrometer.core.instrument.MeterRegistry import io.micrometer.core.instrument.Tags -import io.micrometer.core.instrument.Timer import pl.allegro.tech.servicemesh.envoycontrol.groups.CommunicationMode.ADS import pl.allegro.tech.servicemesh.envoycontrol.groups.CommunicationMode.XDS import pl.allegro.tech.servicemesh.envoycontrol.groups.Group @@ -198,13 +197,10 @@ class SnapshotUpdater( } } - private val updateSnapshotForGroupsTimer = meterRegistry.timer("snapshot.update.duration.seconds") - private fun updateSnapshotForGroups( groups: Collection, result: UpdateResult ): Mono { - val sample = Timer.start() versions.retainGroups(cache.groups()) val results = Flux.fromIterable(groups) .doOnNextScheduledOn(groupSnapshotScheduler) { group -> @@ -222,7 +218,6 @@ class SnapshotUpdater( } } return results.then(Mono.fromCallable { - sample.stop(updateSnapshotForGroupsTimer) result }) }