Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MurmurHash should not override self.hash #4

Open
alindeman opened this issue Mar 28, 2014 · 0 comments
Open

MurmurHash should not override self.hash #4

alindeman opened this issue Mar 28, 2014 · 0 comments
Labels
bug

Comments

@alindeman
Copy link
Owner

This was an accident, but overridding hash to mean something different than "generate a hash code for this object" is bad form. We should rename it compute or similar.
@alindeman alindeman added the bug label Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alindeman