Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2021.x] Fix nacosServiceInstance scheme npe (#3545) #3630

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

ruansheng8
Copy link
Collaborator

cherry pick from #3545

Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuluo-yx yuluo-yx merged commit ffb905a into alibaba:2021.x Mar 3, 2024
3 checks passed
@wu-xin
Copy link

wu-xin commented Dec 26, 2024

2021.1的版本没有重写getScheme,2021.0.6.x的有,比较早的版本又没有? 现在又要加回来吗?

getScheme 这样写会导致一个问题,我用https 请求,会把original的https协议重新组装成http,导致无法使用https请求, 这个不合理吧,因为加了getScheme取到了一个默认的http! 我现在升级到2021.1的版本没问题,后续的版本请慎重考虑并多测试下,感谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants