Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Opus DTX #125

Open
xnorpx opened this issue Apr 4, 2023 · 0 comments · May be fixed by #572
Open

Support for Opus DTX #125

xnorpx opened this issue Apr 4, 2023 · 0 comments · May be fixed by #572

Comments

@xnorpx
Copy link
Collaborator

xnorpx commented Apr 4, 2023

Currently there is no support for dtx.

Add:

Support for dtx in FormatParams
Change Opus packetizer to be able to write markerbit.
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
c15137c 
incase of silence opus rtp payload sets the marker bit after a talking spurt.
usually the data in silence pacekts are empty, just use 1-2 bytes for header.

fixes algesten#125
@ramyak-mehra ramyak-mehra linked a pull request Oct 13, 2024 that will close this issue
Open
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
4199108 
incase of silence opus rtp payload sets the marker bit after a talking spurt.
usually the data in silence pacekts are empty, just use 1-2 bytes for header.

fixes algesten#125
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
f41f799 
incase of silence opus rtp payload sets the marker bit after a talking spurt.
usually the data in silence pacekts are empty, just use 1-2 bytes for header.

fixes algesten#125
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
719738d 
incase of silence opus rtp payload sets the marker bit after a talking spurt.
usually the data in silence pacekts are empty, just use 1-2 bytes for header.

fixes algesten#125
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
097fd42 
incase of silence opus, rtp payload sets the marker bit after a talking spurt.
usually the data in silence packets are empty, it just uses 1-2 bytes for header.

introduced a is_marker state inside the OpusPacketizer since we don't have
access to previous packet incase of audio.

fixes algesten#125
ramyak-mehra added a commit to ramyak-mehra/str0m that referenced this issue Oct 13, 2024
@ramyak-mehra
feat: add marker bit when packetizing opus.
1066c4a 
incase of silence opus, rtp payload sets the marker bit after a talking spurt.
usually the data in silence packets are empty, it just uses 1-2 bytes for header.

introduced a marker state inside the OpusPacketizer since we don't have
access to previous packet incase of audio.

fixes algesten#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add marker bit when packetizing opus. ramyak-mehra/str0m
1 participant
@xnorpx