From 99766278b5ee5fb3cd18d914cbea0c2c1d74474a Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 20 Dec 2024 09:49:22 -0800 Subject: [PATCH] Fix only-`runtime` build on Windows --- .github/workflows/main.yml | 7 ++++++- crates/wasmtime/src/runtime/vm/sys/windows/mod.rs | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 390c263d8f9e..2397a9f322ae 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -526,9 +526,14 @@ jobs: - target: aarch64-pc-windows-msvc os: windows-latest test: cargo check + # While we're here testing a windows target also test a feature'd build + # on Windows. Note that this isn't covered by `micro_checks` above since + # that's for unix platforms, not Windows, so include a small check here + # which isn't the full `micro_checks` matrix but hopefully enough bang + # for our buck. - target: i686-pc-windows-msvc os: windows-latest - test: cargo check + test: cargo check && cargo build -p wasmtime --no-default-features --features runtime # This is used for general compatibility with `#![no_std]` targets and a # variety of crates are tested here. - target: x86_64-unknown-none diff --git a/crates/wasmtime/src/runtime/vm/sys/windows/mod.rs b/crates/wasmtime/src/runtime/vm/sys/windows/mod.rs index 332b56d229e0..90af767f30be 100644 --- a/crates/wasmtime/src/runtime/vm/sys/windows/mod.rs +++ b/crates/wasmtime/src/runtime/vm/sys/windows/mod.rs @@ -2,6 +2,7 @@ use std::cell::Cell; +#[cfg(feature = "signals-based-traps")] pub mod mmap; pub mod traphandlers; pub mod vm;