Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing iframes with divs - issue concerning inline styles #52

Open
bunglegrind opened this issue Sep 5, 2021 · 0 comments · May be fixed by #53
Open

replacing iframes with divs - issue concerning inline styles #52

bunglegrind opened this issue Sep 5, 2021 · 0 comments · May be fixed by #53
Assignees
@alexadam
Labels
bug

Comments

@bunglegrind
Copy link

In

save-as-ebook/web-extension/extractHtml.js

Line 120 in 12a4cbb

function extractIFrames() {

you're converting iframes to divs. The problem is, if an iframe has a style node, you're applying this style to the whole page.
bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Oct 2, 2021
@bunglegrind
fixes alexadam#52
2b8edd0
@bunglegrind bunglegrind linked a pull request Oct 2, 2021 that will close this issue
Open
bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Dec 26, 2021
@bunglegrind
fixes alexadam#52
754f31f
@alexadam alexadam self-assigned this Apr 14, 2023
@alexadam alexadam added the bug label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexadam alexadam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #52 bunglegrind/save-as-ebook
2 participants
@alexadam @bunglegrind