Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Configure Jenkins URL in workspace settings #9

Open
ilkka opened this issue Apr 21, 2017 · 1 comment
Open

Suggestion: Configure Jenkins URL in workspace settings #9

ilkka opened this issue Apr 21, 2017 · 1 comment
Labels

Comments

@ilkka
Copy link

ilkka commented Apr 21, 2017

When deciding on putting the config into a .jenkins file, did you consider adding custom plugin-specific config into the VS Code workspace settings file instead? My first thought is that since this configuration is both project and VS Code specific, that would be the natural place. Or does some other tool use .jenkins files also? Don't get me wrong, I don't think it's bad, this is just me thinking aloud really :)

@alefragnani
Copy link
Owner

Hi @ilkka ,

The main reason is because I created the extension based on the idea of the Travis. It needs to have the configuration file in the root folder because is how the Travis integration works (of course, its file has much more info than mine 😄 ). It was my base model. Also, because the VSCode activation based on file existence only works for files in root folder.

Sure, it could be moved/selected another location for the file . The only downside would be the activation (overall performance), but it's no a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants