Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chords shortcode: refine semantics #16

Closed
alebabai opened this issue Oct 1, 2024 · 0 comments
Closed

Chords shortcode: refine semantics #16

alebabai opened this issue Oct 1, 2024 · 0 comments
Assignees
@alebabai
Labels
enhancement New feature or request

Comments

@alebabai
Copy link
Owner

alebabai commented Oct 1, 2024

what

  • use BEM approach for class names, something like chords chords--inline, chords chords--block
  • refine shortcode api
    • is there a need for the wrap option?
    • make only modifier name configurable (e.g. chords--{{ $modifier }}

why

required for #12
@alebabai alebabai added the enhancement New feature or request label Oct 1, 2024
@alebabai alebabai self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alebabai alebabai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alebabai