Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies broken #12

Open
temp opened this issue Jun 23, 2017 · 2 comments
Open

Dependencies broken #12

temp opened this issue Jun 23, 2017 · 2 comments

Comments

@temp
Copy link

temp commented Jun 23, 2017

When installed with composer --prefer-lowest, the unit tests fail.

Examples:

  • Class 'Symfony\Component\Process\ProcessBuilder' not found
  • Class 'Symfony\Component\Process\ExecutableFinder' not found

Dependency to symfony/process should be at least raised to ^2.1.

@edigu
Copy link

edigu commented Dec 1, 2020

Any updates on this? IMO dependencies are broken even if you did not pass the --prefer-lowest arg.

As a dev who use PHPFFMPeg probe in a project, I noticed the trigger_error deprecation warning recently and start investigating.

  • FFProbeDriver::load calls the Alchemy\BinaryDriver\AbstractBinary::load
  • Then the ProcessBuilderFactory steps in and creates a symfony process builder in constuctor
  • ProcessBuilder is simply not available after the release of symfony/process::v3.4
  • There is no ProcessBuilder exist in symfony 4 or above.

This is an interesting issue, I could not decide if I should raise an issue on php-ffmpeg side or here at the beginning. Seems like even in latest version of this binary driver library, ProcessBuilder factory is assuming that ProcessBuilder is always exist which is wrong. IMO further investigation is needed since composer.json allows symfony 4 with a missing builder dependency.

@edigu
Copy link

edigu commented Dec 1, 2020

Oh. I found this issue which is highly related: PHP-FFMpeg/PHP-FFMpeg#689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants