Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse XML asynchroneously #35

Open
gagern opened this issue Nov 20, 2015 · 0 comments
Open

Parse XML asynchroneously #35

gagern opened this issue Nov 20, 2015 · 0 comments

Comments

@gagern
Copy link
Collaborator

gagern commented Nov 20, 2015

This is a spin-off from #30 (comment).

When passing a callback function to the parse or apply function, they perform their operation asynchroneously. However, when one of the arguments is a string which has to be parsed as an XML document, that parsing happens synchroneously using libxmljs.parseXml. It might be more consistent to replace those synchroneous calls with libxml.Document.fromXmlAsync(buffer, callback) which operates asynchroneously. Or with something similar which allows us to fix the encoding so it doesn't get auto-detected from the file header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants