You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When passing a callback function to the parse or apply function, they perform their operation asynchroneously. However, when one of the arguments is a string which has to be parsed as an XML document, that parsing happens synchroneously using libxmljs.parseXml. It might be more consistent to replace those synchroneous calls with libxml.Document.fromXmlAsync(buffer, callback) which operates asynchroneously. Or with something similar which allows us to fix the encoding so it doesn't get auto-detected from the file header.
The text was updated successfully, but these errors were encountered:
This is a spin-off from #30 (comment).
When passing a callback function to the
parse
orapply
function, they perform their operation asynchroneously. However, when one of the arguments is a string which has to be parsed as an XML document, that parsing happens synchroneously usinglibxmljs.parseXml
. It might be more consistent to replace those synchroneous calls withlibxml.Document.fromXmlAsync(buffer, callback)
which operates asynchroneously. Or with something similar which allows us to fix the encoding so it doesn't get auto-detected from the file header.The text was updated successfully, but these errors were encountered: