From a813fe14ea3eb5c974173ba5a2f882d6cc345cd8 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Mon, 4 Nov 2024 15:37:47 -0500 Subject: [PATCH] Use `|` for consistency --- datafusion/sqllogictest/README.md | 14 +++++++------- datafusion/sqllogictest/test_files/functions.slt | 12 ++++++++---- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/datafusion/sqllogictest/README.md b/datafusion/sqllogictest/README.md index 7a9c53ad0b4e..885e92fee270 100644 --- a/datafusion/sqllogictest/README.md +++ b/datafusion/sqllogictest/README.md @@ -118,21 +118,21 @@ Andrew ``` To test trailing whitespace, project additional non-whitespace column on the -right. For example, by selecting `'XX'` after the column of interest, the test +right. For example, by selecting `'|'` after the column of interest, the test can distinguish between `Andrew` and `Andrew `: ```text -# Note two spaces between `Andrew` and `XX` +# Note two spaces between `Andrew` and `|` query TT -select substr('Andrew Lamb', 1, 7), 'XX'; +select substr('Andrew Lamb', 1, 7), '|' ---- -Andrew XX +Andrew | -# Note only one space between `Andrew` and `XX` +# Note only one space between `Andrew` and `|` query TT -select substr('Andrew Lamb', 1, 6), 'XX'; +select substr('Andrew Lamb', 1, 6), '|' ---- -Andrew XX +Andrew | ``` # Reference diff --git a/datafusion/sqllogictest/test_files/functions.slt b/datafusion/sqllogictest/test_files/functions.slt index 5bc3d2b6b220..a7568d88f797 100644 --- a/datafusion/sqllogictest/test_files/functions.slt +++ b/datafusion/sqllogictest/test_files/functions.slt @@ -738,17 +738,21 @@ true ## Demonstrate how to test for trailing whitespace + +# Note no trailing whitespace query T select substr('Andrew Lamb', 1, 7) ---- Andrew +# Note two spaces between `Andrew` and `|` query TT -select substr('Andrew Lamb', 1, 7), 'XX' +select substr('Andrew Lamb', 1, 7), '|' ---- -Andrew XX +Andrew | +# Note only one space between `Andrew` and `|` query TT -select substr('Andrew Lamb', 1, 6), 'XX' +select substr('Andrew Lamb', 1, 6), '|' ---- -Andrew XX +Andrew |