Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onPanelClosed is triggered when the panel is opening #96

Open
biklas7 opened this issue Jan 30, 2020 · 4 comments · May be fixed by #251
Open

onPanelClosed is triggered when the panel is opening #96

biklas7 opened this issue Jan 30, 2020 · 4 comments · May be fixed by #251

Comments

@biklas7
Copy link

biklas7 commented Jan 30, 2020

If the panel is closed and you open it the onPanelClosed listener is triggered. I think it should only trigger after the panel is opened and then closed, not before opening the panel.
@akshathjain
Copy link
Owner

I'll look into this. I thought I addressed it in a previous update, but I guess the bug is back.

@0aps
Copy link

0aps commented Mar 3, 2021

I can confirm this is still a problem on the latest version. (1.0.2)

@JaffaKetchup
Copy link

JaffaKetchup commented Mar 5, 2021 •
edited
Loading

Hi,
I have this issue as well, and I urgently need it fixed. Please can you look into this?
Thanks.

@Mayb3Nots Mayb3Nots linked a pull request May 19, 2021 that will close this issue
Open
@Mayb3Nots
Copy link

I have created a PR to fix this #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes onPanelClosed call wrongly and added PanelState.HIDDEN Mayb3Nots/sliding_up_panel
5 participants
@0aps @biklas7 @akshathjain @JaffaKetchup @Mayb3Nots