Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots - Deserialize Serialization.WithTransport missing? #85

Open
CumpsD opened this issue Mar 16, 2021 · 0 comments
Open

Snapshots - Deserialize Serialization.WithTransport missing? #85

CumpsD opened this issue Mar 16, 2021 · 0 comments

Comments

@CumpsD
Copy link
Member

CumpsD commented Mar 16, 2021

https://github.com/akkadotnet/Akka.Persistence.PostgreSql/blob/dev/src/Akka.Persistence.PostgreSql/Snapshot/PostgreSqlQueryExecutor.cs#L86

Should this also read:

 // TODO: hack. Replace when https://github.com/akkadotnet/akka.net/issues/3811
if (serializerId.HasValue)
    return Serialization.Deserialize((byte[])payload, serializerId.Value, manifest);

// Support old writes that did not set the serializer id
var deserializer = Serialization.FindSerializerForType(type, Configuration.DefaultSerializer);
return Serialization.WithTransport(Serialization.System, () => deserializer.FromBinary((byte[])payload, type));

Identical to Akka.Persistence.PostgreSql\Journal\PostgreSqlQueryExecutor.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant