Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some posts display thumbnail image but not full-size preview, or vice-versa #10

Open
ajh3 opened this issue Nov 14, 2018 · 1 comment
Open

Some posts display thumbnail image but not full-size preview, or vice-versa #10

ajh3 opened this issue Nov 14, 2018 · 1 comment
Assignees
@ajh3
Labels
bug Something isn't working

Comments

@ajh3
Copy link
Owner

ajh3 commented Nov 14, 2018

Seems to be a bug in the reddit API, but should be able to work around it
@ajh3 ajh3 self-assigned this Nov 14, 2018
@ajh3 ajh3 added the bug Something isn't working label Nov 27, 2018
@ajh3
Copy link
Owner Author

ajh3 commented Dec 2, 2018 •
edited
Loading

42b5b11 solves half of this, namely, Glide was trying to show animated images in PostFragment which downloaded so slowly (for unknown reasons) that the image appeared not to load.

the other half, missing post thumbnails, still needs to be fixed. this should only happen for cases where reddit cannot generate a thumbnail, or cases where the user is logged out and the subreddit disables thumbnails. for some reason NoSurf is not displaying thumbnails in the latter case even when the user is logged in. https://www.reddit.com/r/redditdev/comments/a2awdk/api_returns_default_for_post_thumbnail_even/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajh3 ajh3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajh3