Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename enable/disable button to enabled/disabled #257

Open
Doksha opened this issue May 22, 2024 · 2 comments
Open

Rename enable/disable button to enabled/disabled #257

Doksha opened this issue May 22, 2024 · 2 comments

Comments

@Doksha
Copy link

Doksha commented May 22, 2024

To enable the extension, you click disable, and to disable it you click enable.
The state (on or off) of the actual switch is correct (on for enabled, off for disabled)

Alternatively, just make it past tense so the text reflects the current state.

@ajayyy ajayyy changed the title Disable/enable button has opposite language. Rename enable/disable button to enabled/disabled May 22, 2024
@jgoedde
Copy link
Contributor

jgoedde commented Sep 10, 2024

Hey,

I wanted to provide an update on the progress for this issue. I've forked the repo and have update the langkeys.

Only thing that's not so clear to me is where to add the new langKey "Enabled". Do I commit the new text to /public/_locales submodule?

What's left:

  • Adding the new lang key (Enabled) to the translation system. Disabled lang key already existed.

I'd appreciate any feedback on my approach so far before I move forward. You can check my forked branch here.

Thanks!

@jgoedde
Copy link
Contributor

jgoedde commented Sep 10, 2024

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants