Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Hardcoded variables #19

Open
HelinXu opened this issue May 28, 2022 · 0 comments
Open

[Bug Report] Hardcoded variables #19

HelinXu opened this issue May 28, 2022 · 0 comments

Comments

@HelinXu
Copy link

HelinXu commented May 28, 2022

Hi!

Thanks for open sourcing this amazing work!

I might be wrong, but I think several hardcoded variables should have been passed in through the config file. e.g. in the following example, the min_pts_num=50 should have been passed in via the cluster_npoint_thre: 50 in the config file.

proposal_idx, proposal_len, scores = self.generate_proposal(mask_logits.squeeze(dim=0).sigmoid(), object_idxs,
threshold=0.5, seg_pred=semantic_preds_, inst_pred_seg_label=inst_pred_seg_label,
min_pts_num=50)

This took me quite a moment, as small objects with fewer than 50 points were missing in the outputs, even if I turned cluster_npoint_thre in the config file to 5 : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant