Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PwCalculation Input Validator assumes "parameters" is given #1035

Open
eric-read opened this issue Jun 19, 2024 · 1 comment
Open

PwCalculation Input Validator assumes "parameters" is given #1035

eric-read opened this issue Jun 19, 2024 · 1 comment

Comments

@eric-read
Copy link

The top-level validate_inputs validator for the PwCalculation will always try to get the parameters from the inputs. This causes any higher-level workchains that wrap PwBaseWorkChain that want to provide the Quantum-Espresso input parameters on the fly would have to set the PwBaseWorkChain validator to None in its own define method. A fix similar to 4ede7a1 and a3896293 could be implemented by checking if the parameter port is present in the namespace, since workchains that provide the parameters input on the fly typically would exclude that port when exposing the PwBaseWorkChain inputs. Therefore avoiding the need for such workchains to have to set the PwBaseWorkChain validator to None in their own define method.

@mbercx
Copy link
Member

mbercx commented Jun 20, 2024

Thanks for reporting @eric-read! Seems sensible to check the existence of the port indeed, let me open a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants