Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TEST fails swig tests #124

Open
robinvanemden opened this issue Jun 17, 2020 · 2 comments
Open

Make TEST fails swig tests #124

robinvanemden opened this issue Jun 17, 2020 · 2 comments
Assignees

Comments

@robinvanemden
Copy link
Contributor

robinvanemden commented Jun 17, 2020

Probably a known issue, but I thought I'd report it here anyway. make TEST produces the following SWIG related errors:

Running tests in ===|swig|===
----------------------------------------------------------------------
Ran 726 tests in 0.194s

OK

Running tests in ===|parser|===
ERROR (GRAPH): some of graph RNN_graph's node dnnc___1's
               inputs are not connected to other nodes in the graph.
ERROR (TYPE INFER): cound not find all nodes for dnnc___1,
ERROR (CODEGEN): cound not find all nodes for dnnc___1,
                 an instance of RNN.
                 Please check model's sanity and try again.
ERROR (GRAPH): some of graph Loop_graph's node dnnc___1's
               outputs are not connected to other nodes in the graph.
ERROR (CODEGEN): cound not find all nodes for dnnc___1,
                 an instance of Loop.
                 Please check model's sanity and try again.
ERROR (GRAPH): some of graph If_graph's node 2's
               inputs are not connected to other nodes in the graph.
ERROR (GRAPH): some of graph BatchNormalization_graph's node dnnc___1's
               inputs are not connected to other nodes in the graph.
ERROR (GRAPH): some of graph BatchNormalization_graph's node 1's
               outputs are not connected to other nodes in the graph.
ERROR (TYPE INFER): cound not find all nodes for dnnc___1,
ERROR (CODEGEN): cound not find all nodes for dnnc___1,
                 an instance of BatchNormalization.
                 Please check model's sanity and try again.
ERROR (GRAPH): some of graph GRU_graph's node dnnc___1's
               inputs are not connected to other nodes in the graph.
ERROR (TYPE INFER): cound not find all nodes for dnnc___1,
ERROR (CODEGEN): cound not find all nodes for dnnc___1,
                 an instance of GRU.
                 Please check model's sanity and try again.
read 130 files.
----------------------------------------------------------------------
Ran 1 test in 0.042s

@srohit0 srohit0 self-assigned this Jun 17, 2020
@srohit0
Copy link
Member

srohit0 commented Jun 17, 2020

Yes, all these failing tests are valid errors thrown by sanity check on a graph created by a single operator.

Need to find a cleaner way to rearrange tests into positive and negative tests.

@robinvanemden
Copy link
Contributor Author

That makes sense - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants