Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external tool dependency #2

Open
agzam opened this issue Oct 5, 2022 · 3 comments
Open

Remove external tool dependency #2

agzam opened this issue Oct 5, 2022 · 3 comments

Comments

@agzam
Copy link
Owner

agzam commented Oct 5, 2022

There's gotta be a way to retrieve subs without using youtube-dl.

@novoid
Copy link

novoid commented Oct 8, 2022

As you have written in this reddit comment, I would prefer the ability to retrieven auto-generated subtitles using your tool. If this requires getting rid of youtube-dl dependency, it shall be so.

By the way, I do think that https://github.com/yt-dlp/yt-dlp (a fork) is the preferred tool to use instead of youtube-dl.

@agzam
Copy link
Owner Author

agzam commented Oct 15, 2022

Excellent. It looks like yt-dlp does nicely extract auto-generated subs. I'm gonna rewrite the package to use it, instead of youtube-dl. Thank you!

@agzam agzam changed the title Remove youtube-dl dependency Remove external tool dependency Oct 19, 2022
@agzam
Copy link
Owner Author

agzam commented Oct 19, 2022

@novoid Moved to yt-dlp. I still would like to explore the idea of removing external dependency altogether. But now it properly works with both normal and auto-generated subs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants