Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminal support for mac with example .comeback file #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add terminal support for mac with example .comeback file #48

wants to merge 2 commits into from

Conversation

ktamir
Copy link
Collaborator

@ktamir ktamir commented Apr 11, 2019

Fixes #31

yammesicka
yammesicka reviewed Apr 11, 2019
View reviewed changes
comeback/plugins/terminal/main.py Outdated
from comeback import utils


def check_plugin(cwd: str = None) -> utils.RUN_STATUS:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Optional[str]

comeback/plugins/terminal/main.py Outdated


def run_windows(cwd: str) -> utils.RUN_STATUS:
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise NotImplementedError()

@agamm
Copy link
Owner

agamm commented May 10, 2019

@yammesicka @ktamir any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka yammesicka left review comments

@agamm agamm Awaiting requested review from agamm

@yoavgolan yoavgolan Awaiting requested review from yoavgolan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a terminal plugin
3 participants
@ktamir @agamm @yammesicka