Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core config feature is not working as expected. #184

Open
wtrocki opened this issue Jul 27, 2021 · 2 comments
Open

Core config feature is not working as expected. #184

wtrocki opened this issue Jul 27, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Jul 27, 2021

Feature or problem description

I have been playing with the config and it looks like it is not working as it should.

Config is not properly strongly typed:

	cfg interface{}

Config should provide interface for load and save where save and load triggered from the plugin will actually execute top level save and load functions and return proper results. Go doesn't support generics but what we really need to is to bridge specific load and save functions in plugin with host cli. If we can override plugin save methods and load methods on the host that will be all that is needed.

The current implementation is crashing for me when setting up in root and plugin with sample config on MergePluginCfg.

@wtrocki wtrocki added the enhancement New feature or request label Jul 27, 2021
@namit-chandwani
Copy link
Member

I'll look into it

@wtrocki
Copy link
Contributor Author

wtrocki commented Aug 9, 2021

What is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants