Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the license is invalid #2159

Closed
ivan-mogilko opened this issue Oct 5, 2023 · 3 comments
Closed

Link to the license is invalid #2159

ivan-mogilko opened this issue Oct 5, 2023 · 3 comments
Assignees
Labels
context: project related to the project and its organization type: bug unexpected/erroneous behavior in the existing functionality

Comments

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Oct 5, 2023

We have a link which is supposed to open Artistic License 2 text in the License.txt, and every code file header. The link is:
http://www.opensource.org/licenses/artistic-license-2.0.php

Recently I tried to open this link and was told that this page cannot be found. I do not know whether it was available earlier, and when did it become invalid.

Searching the opensource.org for Artistic License 2 points to this page instead:
https://opensource.org/license/artistic-2-0/

I guess we should replace the link everywhere through the repository, in the maintained branches (starting with release-3.6.0), in the manual, and on the website, if it also is present there.
(Also see #2131)

@ivan-mogilko ivan-mogilko added the context: project related to the project and its organization label Oct 5, 2023
@ivan-mogilko ivan-mogilko added this to the 3.6.0 maintenance milestone Oct 5, 2023
@ivan-mogilko ivan-mogilko added the type: bug unexpected/erroneous behavior in the existing functionality label Oct 5, 2023
@ivan-mogilko
Copy link
Contributor Author

Since there's a need to adjust all the source file headers, in them we have the copyright years written as:
// Copyright (C) 1999-2011 Chris Jones and 2011-20xx others

I always wondered if this is permitted to do something like this. Others (major projects at least) seem to just update each year, for example:
libsdl-org/SDL@fde78d1

@ivan-mogilko ivan-mogilko self-assigned this Nov 5, 2023
@ivan-mogilko
Copy link
Contributor Author

I think the best way would be to write another python script in Scripts/ dir and add one that runs through the whole repo and applies this to all files that need and contain this form. Values may be read from version.json as well.

@ivan-mogilko
Copy link
Contributor Author

Fixed by #2212 in multiple branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: project related to the project and its organization type: bug unexpected/erroneous behavior in the existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant