Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PinCodeSecurityOptions.RolesWithoutPin has no effect #242

Open
janmuncinsky opened this issue Oct 4, 2023 · 0 comments
Open

PinCodeSecurityOptions.RolesWithoutPin has no effect #242

janmuncinsky opened this issue Oct 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@janmuncinsky
Copy link

This setting is ignored by the system. I guess this is because the user authorization is now handled in the PagePreviewPartialRouter, which is called during endpoint resolution in the EndpointRoutingMiddleware, and if the recommended order of middlewares is configured, the user is not authenticated in this stage yet.
Wouldn't be a better idea to register a new Authorization handler? This way authorization would be handled from AuthorizationMidleware, where it belongs and the issue with RolesWithoutPin could be solved.

@barteksekula barteksekula added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants