-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portrait mode assets are cropped in the asset share page #84
Comments
Correct - do you have a better universal solution? |
I will try a few things out and suggest a solution if it handles both portrait and landscape images properly. Thanks for the quick response! |
Happy to incorporate - this was the hang that seemed to look best across sizes that we found. We didn’t like variable height cards since they tended to make uneven rows which are hard to scan. Something we could do as well is add a “thumbnail style” to the results components that supports a few different approaches so users can choose if it’s more important to them. |
Hang = best (not edit of comment on phone ;)) |
I totally agree about images with less content at the top, and this begs an interesting question my manager had...would it make sense to allocate more of the card real estate to the image and less to the title, data and actions? If this were a viable option it might mitigate the issue if the object-position property were changed from "center" to "top"...thoughts? |
yes that could be a good enhancement to offer a few different thumbnail size options. Not sure if you have seen this @artdirk: https://adobe-marketing-cloud.github.io/asset-share-commons/pages/development/guide/ -> Extend Search Results Renderer. Its fairly easy to create a custom Card / List renderer to add/modify the metadata displayed but could also be used to change the size of the card thumbnail. |
To allow authors to configure the size.. im wondering how that might look since since we don't have a way to "Author" different views; you just pick the renderer. It seems like the most reasonable option would be to add 2 more options to the above that are Thumbnail size, Thumbnail position (top, center, bottom, cover, etc.) Size gets interesting since we can't do pixels since the card and list views thumbs wont be the same height; so we could do a % off whatever is the "default heights" (50%, 100%, 200%, 500% etc) or we could create some arbitrary list of sizes (Small, Medium, Large) and each is set to some predefined height (Not sure what granularity of sizes would make everyone happy - if that's possible) |
Portrait mode assets are cropped such that only their centers are shown within the asset share page.
Card layout
List layout
The text was updated successfully, but these errors were encountered: