Blather does not gracefully handle server-side error on connect

[bklang]

Following is an example (very short) session where the XMPP server is unable to handle a new connection. Blather received an Internal Server Error with text "Can't find application for stream message" from the server. Instead of passing up some kind of Internal Server Error exception, Blather tells the server that the XML it received was not well formed.

Client (Blather)
<stream:stream to='127.0.0.1' xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' version='1.0' xml:lang='en' >

Server
<stream:error><internal-server-error xmlns="urn:ietf:params:xml:ns:xmpp-streams"/><text xml:lang="en" xmlns="urn:ietf:params:xml:ns:xmpp-streams">Can't find application for stream message.</text></stream:error></stream:stream>

Client
<stream:error><xml-not-well-formed xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error></stream:stream><stream:error><xml-not-well-formed xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error>

Server
</stream:stream>

Client
<stream:error><xml-not-well-formed xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error>

[benlangfeld]

This is because a ParseError is being raised. I'll run this through the parser later on to figure out why it's invalid, because I'm not quite seeing it right now.

[benlangfeld]

Can you give steps to reproduce? I'm struggling to get it to break the parser manually and I'm starting to suspect it might be a weird encoding issue. Alternatively, inspecting the ParseError here might be nice: https://github.com/sprsquish/blather/blob/develop/lib/blather/stream.rb#L157

[bklang]

I am able to reproduce it using netcat. I start a fake "server" with nc -l 5222 which opens a simple TCP listener on port 5222. Then I run my Blather client to connect to that server. When Blather connects I see the stream request come in and I paste the first Server response listed above. The exact same error results.