Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "data-cy" props and attributes to "all" inputs #1609

Open
NicoJolyAdeo opened this issue Aug 6, 2024 · 2 comments
Open

Add "data-cy" props and attributes to "all" inputs #1609

NicoJolyAdeo opened this issue Aug 6, 2024 · 2 comments
Labels
🚀 feat A new feature ❌ wont fix This will not be worked on

Comments

@NicoJolyAdeo
Copy link

I want to propose an evolution/improvement on

Component

Description

It's sometimes difficult to get a selector (from ADS component) to test it (E2E/Cypress,...)...
So, is it possible to add an attribute and props with "data-cy" (for example) on each input ?

Describe the solution you would like

Add attribute "data-cy" with generic value "..." and props "prefix" and "suffix" (optionals), like :

In MButton.vue :
<button data-cy="prefix?-" + "-the-unique-generic-datacy-name-for-this-button-in-this-component" + "-suffix?" />
<button data-cy="prefix?-" + "-the-unique-generic-datacy-name-for-this-button-in-this-component" + "-suffix?" />

Describe the alternatives you considered

No response

Additional comments

No response

@NicoJolyAdeo NicoJolyAdeo added the 🚀 feat A new feature label Aug 6, 2024
@mohamedMok mohamedMok added the ❌ wont fix This will not be worked on label Sep 2, 2024
@mohamedMok
Copy link
Contributor

Hello @NicoJolyAdeo,

Thanks for your feeback, but this won't be part of the design system.
It should and could be managed by the users. In most of our librairies you can pass attributes on the components

@NicoJolyAdeo
Copy link
Author

It was in the cards, though, and an attribute appears in the "doc" about it.
QA (Quality) could be part of the ADS i think.

Capture d'écran 2024-09-02 164445

@NicoJolyAdeo NicoJolyAdeo reopened this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat A new feature ❌ wont fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants